This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Add HMAC middleware #8
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-h
suggested changes
Jul 13, 2020
cedric-h
suggested changes
Jul 13, 2020
Co-authored-by: Cedric Hutchings <cedhut02@gmail.com>
cedric-h
suggested changes
Jul 13, 2020
Contributor
cedric-h
left a comment
cedric-h
left a comment
There was a problem hiding this comment.
Looks good to me, I just think we need to be consistent about how we do multiple imports from the same source.
Co-authored-by: Cedric Hutchings <cedhut02@gmail.com>
In my suggestion, I failed to specify that a line was taking the place of three separate lines, not just the one highlighted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Middleware to authenticate requests to the API via HMAC.
Closes #6