zshrc: smarter smarter cd #142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to account for a lot of possibilities (see zshbuiltins(1)): we stay on the safe side and only change cd target if we're sure about what we do. See examples: % zsh -d -f # reset the shell % cd % touch -- -q % cd -q # should do nothing; 43090cf version behaves weirdly here, replacing -q with . % cd /home % cd /home /etc # should go to /etc (replace home with etc in PWD) /etc % cd /home /etc # this will fail [1] cd: string not in pwd: /home % cd /home % cd -q /home /etc # should go to /etc /etc % cd -q /home /etc # this will fail [2] cd: string not in pwd: /home % cd % touch +123456 % cd +123456 # this will fail [3]; 43090cf version behaves weirdly here, replacing +123456 with . [1] I chose to make this one work. If `cd old new` fails, then try to `cd old` [2,3] I chose to fail too in that case. Handling cd arguments is not what I was planning to do when I started working on this patch ;P
Member
Contributor
Author
|
You probably want to run some more tests on it. I ran a few and made sure my usecases were covered, though I might have missed some. Even got to learn about zshbuiltins(1) in the process! |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
|
@ft maybe you could please take a look at this once you've some spare minutes? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to account for a lot of possibilities (see zshbuiltins(1)): we stay on the safe side and only change cd target if we're sure about what we do. See examples: