fix: escape single quotes in descriptions and deprecation reasons #2924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-inspector/action |
5.0.16-alpha-20251209221244-ff89fd2707cf16b24ef14c13d056b38377608670 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/cli |
6.0.4-alpha-20251209221244-ff89fd2707cf16b24ef14c13d056b38377608670 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/audit-command |
5.0.16-alpha-20251209221244-ff89fd2707cf16b24ef14c13d056b38377608670 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/coverage-command |
6.1.10-alpha-20251209221244-ff89fd2707cf16b24ef14c13d056b38377608670 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/diff-command |
6.0.4-alpha-20251209221244-ff89fd2707cf16b24ef14c13d056b38377608670 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/introspect-command |
5.0.16-alpha-20251209221244-ff89fd2707cf16b24ef14c13d056b38377608670 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/similar-command |
5.0.16-alpha-20251209221244-ff89fd2707cf16b24ef14c13d056b38377608670 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/validate-command |
5.0.16-alpha-20251209221244-ff89fd2707cf16b24ef14c13d056b38377608670 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/core |
7.0.4-alpha-20251209221244-ff89fd2707cf16b24ef14c13d056b38377608670 |
npm ↗︎ unpkg ↗︎ |
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://pr-2924.graphql-inspector.pages.dev |
n1ru4l
reviewed
Dec 8, 2025
jdolle
approved these changes
Dec 8, 2025
Collaborator
jdolle
left a comment
jdolle
left a comment
There was a problem hiding this comment.
Great! We have this escape formatting for enum and this PR applies that same logic to the remaining changes.
n1ru4l
approved these changes
Dec 8, 2025
Collaborator
n1ru4l
left a comment
n1ru4l
left a comment
There was a problem hiding this comment.
Just one small comment here that I noticed: https://github.com/graphql-hive/graphql-inspector/pull/2924/files#r2599154883
adambenhassen
force-pushed
the
adam/singe-quotes-fix
branch
from
34aadc8 to
ff89fd2
Compare
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation for #2903
Description
Applies fmt escaping to user-provided text fields in diff change messages to prevent malformed output when values contain single quotes (e.g., "it's", "don't")
Type of change