Skip to content

Conversation

@secprog
Copy link

@secprog secprog commented Dec 5, 2025

This update introduces an optional task_store parameter to the to_a2a function, allowing users to provide a custom task store instance. If not specified, the function defaults to using InMemoryTaskStore. Additionally, unit tests have been added to verify the functionality with a custom task store.

Replaces my old closed PR #3639.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @secprog, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the to_a2a function by enabling the injection of custom task store implementations. This change provides greater flexibility for developers to integrate the A2A application with various task management backends, moving beyond the default in-memory solution. The update includes necessary code modifications to support this new parameter and comprehensive unit tests to ensure its correct behavior.

Highlights

  • Custom Task Store Support: The to_a2a function now accepts an optional task_store parameter, allowing users to provide their own TaskStore implementation for managing tasks.
  • Default Behavior: If no custom task_store is provided, the to_a2a function will gracefully fall back to using the InMemoryTaskStore as before.
  • Enhanced Test Coverage: New unit tests have been added to thoroughly validate the functionality of to_a2a when a custom task store is supplied, ensuring correct integration and behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the core [Component] This issue is related to the core interface and implementation label Dec 5, 2025
@adk-bot
Copy link
Collaborator

adk-bot commented Dec 5, 2025

Response from ADK Triaging Agent

Hello @secprog, thank you for creating this PR!

To help us review this PR, could you please associate a GitHub issue with it? If there is no existing issue, could you please create one?

In addition, could you please add a testing plan section to your PR description to describe how you tested your changes?

This information will help reviewers to review your PR more efficiently. Thanks!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the to_a2a function by adding an optional task_store parameter. This allows users to inject a custom task store, providing more flexibility, while defaulting to InMemoryTaskStore for backward compatibility and ease of use. The implementation is clean and follows best practices. A corresponding unit test has been added to verify that a provided custom task store is used correctly and that the default is not instantiated in that case. The changes are well-executed and improve the utility of the to_a2a function. Overall, this is a great contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core [Component] This issue is related to the core interface and implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants