-
-
Notifications
You must be signed in to change notification settings - Fork 11
Add a page on resources used by contributors #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Ivorforce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh this is great! Finally a place to link all those resources!
|
|
||
| - **Link:** `benchmarks.godotengine.org <https://benchmarks.godotengine.org/>`__ | ||
| - `Source code <https://github.com/godotengine/godot-benchmarks/tree/main/web>`__ | ||
| (maintained by `Calinou <https://github.com/Calinou>`__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I would mention maintainers by name here. We don't do this for other areas of the engine either, and it's not super relevant to the technical information presented here.
...Though I guess there's a point to be made for it since these tools don't have teams maintaining them, so this is the only place we can mention the maintainers.
So idk, anybody else have an opinion?
2f01236 to
756e661
Compare
Ivorforce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This provides a centralized view of all web resources commonly referred to by contributors. It also lists the maintainer(s) for each resource, so you know who to contact if there is a particular issue.