-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
pnpm-lock: upgrade deps to address vulnerabilities #36103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v1.25
Are you sure you want to change the base?
Conversation
There are a few vulnerabilities reported with: ``` npx pnpm audit ... 6 vulnerabilities found Severity: 2 moderate | 3 high | 1 critical ``` Fix them by upgrading.
|
I am not very good with javascript, the lock file updates look less targeted than the resolution updates. |
|
We should submit the PR to the main branch first and then backport it to v1.25. Otherwise, the bug may reappear during future upgrades. |
I do not see any vulnerabilities on the main branch. Unless I am holding pnpm wrong |
|
Thanks! |
|
Cc @silverwind |
|
I have no idea if these upgrades break the gitea UI though :-/ |
|
Maintainers note: This targets the 1.25 branch. These are solved in nightly already |
|
Aha, my client hadn't updated yet so I didn't see the above comments already re: main branch |
|
It is not necessary to edit |
silverwind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
|
Try this: |
There are a few vulnerabilities reported with:
Fix them by upgrading.