-
Notifications
You must be signed in to change notification settings - Fork 25
Implement exercise T4L2/tags-update #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Opened PR early while waiting to be assigned. Feel free to close if there are duplicates in the future, or if someone else is assigned to this exercise in the future. This would serve as potential reference to others looking for implementations of exercises as well. |
woojiahao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jovnc for working on this exercise! I think that there are some major comments on the ordering of grading, less on the coding style, more so on the autograding philosophy. I will need to update the public documentation to capture this logic too
|
@woojiahao Thanks for the PR review, and the very detailed comments. I have made the changes based on your comments, namely here are the main changes:
|
|
LGTM, let's wait for @woojiahao's input on the change to the |
|
Given there is a new utility function |
e9d1f3a to
c32e219
Compare
c32e219 to
8903401
Compare
|
@VikramGoyal23 @woojiahao I have made some changes, and would like to ask for a review again, thanks! If there are any changes, do let me know and I'll quickly make the changes, otherwise we can merge this PR |
Exercise Review
Exercise Discussion
Fixes #62
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?