Skip to content

Conversation

@kea-S
Copy link
Contributor

@kea-S kea-S commented Nov 16, 2025

Exercise Review

merge-undo

Exercise Discussion

#67

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested the download script using test-download.sh?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@woojiahao woojiahao self-assigned this Nov 20, 2025
@woojiahao woojiahao added exercise review Review a proposed exercise discussing labels Nov 20, 2025
@woojiahao woojiahao linked an issue Nov 20, 2025 that may be closed by this pull request
1 task
Copy link
Member

@woojiahao woojiahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The autograding and unit testing LGTM! Just comments on the download itself. Thank you!

@jovnc
Copy link
Collaborator

jovnc commented Dec 6, 2025

Hi @kea-S , is this PR currently being worked on?

Would be good to get an update by 9 Dec, else we need to close this PR, so that we can resolve this issue. Thanks!

@kea-S
Copy link
Contributor Author

kea-S commented Dec 8, 2025

Hi @kea-S , is this PR currently being worked on?

Would be good to get an update by 9 Dec, else we need to close this PR, so that we can resolve this issue. Thanks!

Apologies, Just saw this message today, I've made the changes as requested but would like to point out that my test-downloads.sh doesn't work anymore since removing the res/README.md file.

@jovnc jovnc changed the title Implement T6L2 merge undo Implement exercise T6L2/merge-undo Dec 12, 2025
@jovnc jovnc assigned jovnc and unassigned woojiahao Dec 13, 2025
Copy link
Collaborator

@jovnc jovnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added the fix for issue with README.md in download.py and cleaned the code abit. Thank you @kea-S for your contribution and addressing the comments in the PR! Will be merging the PR!

@jovnc jovnc merged commit e1614c0 into git-mastery:main Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussing exercise review Review a proposed exercise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Exercise Discussion] T6L2/merge-undo

3 participants