-
Notifications
You must be signed in to change notification settings - Fork 25
Implement exercise T6L2/merge-undo #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
woojiahao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The autograding and unit testing LGTM! Just comments on the download itself. Thank you!
|
Hi @kea-S , is this PR currently being worked on? Would be good to get an update by 9 Dec, else we need to close this PR, so that we can resolve this issue. Thanks! |
Apologies, Just saw this message today, I've made the changes as requested but would like to point out that my test-downloads.sh doesn't work anymore since removing the res/README.md file. |
jovnc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added the fix for issue with README.md in download.py and cleaned the code abit. Thank you @kea-S for your contribution and addressing the comments in the PR! Will be merging the PR!
Exercise Review
merge-undo
Exercise Discussion
#67
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?