Skip to content

Conversation

@keerthigkaarthik
Copy link
Contributor

Exercise Review

Exercise Discussion

#66

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested the download script using test-download.sh?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@keerthigkaarthik keerthigkaarthik changed the title Add exercise branch forward Implement exercise branch forward Nov 17, 2025
@keerthigkaarthik keerthigkaarthik changed the title Implement exercise branch forward Implement exercise T6L2/branch-forward Nov 17, 2025
@woojiahao woojiahao self-assigned this Nov 20, 2025
@woojiahao woojiahao added exercise review Review a proposed exercise discussing labels Nov 20, 2025
@woojiahao woojiahao linked an issue Nov 20, 2025 that may be closed by this pull request
1 task
Copy link
Member

@woojiahao woojiahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a preliminary question about the autograding schema! I'll review the unit tests when we flesh out the autograding

Copy link
Collaborator

@jovnc jovnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on verification process.

@jovnc
Copy link
Collaborator

jovnc commented Dec 6, 2025

Hi @keerthigkaarthik , is this PR currently being worked on?

Would be good to get an update by 9 Dec, else we need to close this PR, so that we can resolve this issue. Thanks!

@keerthigkaarthik
Copy link
Contributor Author

keerthigkaarthik commented Dec 6, 2025 via email

@keerthigkaarthik
Copy link
Contributor Author

keerthigkaarthik commented Dec 9, 2025

Sorry for the wait!

Copy link
Collaborator

@jovnc jovnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @keerthigkaarthik for addressing the comments, there is still some small refactoring needed for verify.py and we can also remove one test which is causing some issues locally. Other than that, I think we are ready to merge this PR! I'll see if I can make a commit to help rectify this.

Copy link
Collaborator

@jovnc jovnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good enough for now, and if there are any issues in the future, we can still rectify it. I'll go ahead with the merge, thanks @keerthigkaarthik for the contribution!

@jovnc jovnc merged commit 521f1ac into git-mastery:main Dec 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussing exercise review Review a proposed exercise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Exercise Discussion] T6L2/branch-forward

4 participants