-
Notifications
You must be signed in to change notification settings - Fork 25
Implement exercise T6L2/branch-forward #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement exercise T6L2/branch-forward #118
Conversation
woojiahao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a preliminary question about the autograding schema! I'll review the unit tests when we flesh out the autograding
jovnc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on verification process.
|
Hi @keerthigkaarthik , is this PR currently being worked on? Would be good to get an update by 9 Dec, else we need to close this PR, so that we can resolve this issue. Thanks! |
|
Yep, sorry but I'll only be able to get around to it on Tuesday. I'll make
the changes within the day. Thanks!
…On Sat, 6 Dec 2025, 08:52 jovnc, ***@***.***> wrote:
*jovnc* left a comment (git-mastery/exercises#118)
<#118 (comment)>
Hi @keerthigkaarthik <https://github.com/keerthigkaarthik> , is this PR
currently being worked on?
Would be good to get an update by 9 Dec, else we need to close this PR, so
that we can resolve this issue. Thanks!
—
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4UK3LASUU5ZX66X7THXVZL4AKDMHAVCNFSM6AAAAACMDAHVCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMJZG4YDINBUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sorry for the wait! |
jovnc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @keerthigkaarthik for addressing the comments, there is still some small refactoring needed for verify.py and we can also remove one test which is causing some issues locally. Other than that, I think we are ready to merge this PR! I'll see if I can make a commit to help rectify this.
jovnc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good enough for now, and if there are any issues in the future, we can still rectify it. I'll go ahead with the merge, thanks @keerthigkaarthik for the contribution!
Exercise Review
Exercise Discussion
#66
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?