fix: add explicit white color to default subtitle text #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default subtitle text in all control widgets (Cupertino, Material, and Material Desktop) did not specify an explicit text color. This could cause subtitles to be invisible on certain themes where the default text color is dark, as subtitles are rendered on a semi-transparent black background. This fix adds explicit `color: Colors.white` to ensure subtitle text is always visible regardless of the app's theme configuration. Addresses fluttercommunity#914
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #934 +/- ##
=======================================
Coverage 43.84% 43.84%
=======================================
Files 21 21
Lines 1601 1601
=======================================
Hits 702 702
Misses 899 899 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
color: Colors.whiteto the default subtitle text rendering in all control widgetsColor(0x96000000)), so dark text colors can be invisibleChanges
lib/src/cupertino/cupertino_controls.dart- Added white color to subtitle TextStylelib/src/material/material_controls.dart- Added white color to subtitle TextStylelib/src/material/material_desktop_controls.dart- Added white color to subtitle TextStyleTest plan
subtitleBuilderare unaffected)Addresses #914
🤖 Generated with Claude Code