-
-
Notifications
You must be signed in to change notification settings - Fork 67
chore: improve plain releases for local builds #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doorgan
wants to merge
4
commits into
main
Choose a base branch
from
doorgan/plain-releases
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e4f4dd1
chore: improve plain releases for local builds
doorgan fa0d5fa
fix: remove leftover file
doorgan 8a72b9d
fix: use full executable path in the release announcement
doorgan af7cb91
refactor: rename release-plain to release and release-local/all to bu…
doorgan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,4 +59,41 @@ defmodule Expert.Release do | |
|
|
||
| release | ||
| end | ||
|
|
||
| def plain_assemble(release) do | ||
| executable = if windows?(), do: "start_expert.bat", else: "start_expert" | ||
| executable_path = Path.join([release.path, "bin", executable]) | ||
|
|
||
| # Make the executable script runnable | ||
| File.chmod!(executable_path, 0o755) | ||
|
|
||
| if release.options[:quiet] do | ||
| release | ||
| else | ||
| Mix.shell().info(""" | ||
|
|
||
| #{IO.ANSI.bright()}✨ Expert build created at:#{IO.ANSI.reset()} #{release.path} | ||
|
|
||
| To use it, point your editor LSP configuration to: | ||
|
|
||
| #{executable_path} --stdio | ||
|
|
||
| You can also run Expert in TCP mode by passing the `--port PORT` argument: | ||
|
|
||
| #{executable_path} --port 9000 | ||
|
|
||
| To get a list of all available command line options, run: | ||
|
|
||
| #{executable_path} --help | ||
| """) | ||
|
|
||
| # Silence the release "announce" message | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't like the default announcement message because it's misleading, you can't run expert with them and you can't pass cli flags to |
||
| new_opts = Keyword.put(release.options, :quiet, true) | ||
| %{release | options: new_opts} | ||
| end | ||
| end | ||
|
|
||
| def windows? do | ||
| :os.type() |> elem(0) == :win32 | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #!/bin/sh | ||
|
|
||
| cd -P -- "$(dirname -- "$0")" | ||
| exec ./plain eval "System.no_halt(true); Application.ensure_all_started(:xp_expert)" "$@" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| @echo off | ||
|
|
||
| cd /d "%~dp0" | ||
| .\plain.bat eval "System.no_halt(true); Application.ensure_all_started(:xp_expert)" --stdio | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want all of these to show the full executable_path, for consistency.