fix: position encoding to ensure correct formatting for special chars #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingyplus
force-pushed
the
fix-utf-16-encoding
branch
from
bcf9fb2 to
32feee0
Compare
mhanberg
reviewed
Dec 10, 2025
| assert result == formatted() | ||
| end | ||
|
|
||
| test "iss 242", %{project: project} do |
Member
There was a problem hiding this comment.
change this to be a real test name please
mhanberg
changed the title
mhanberg
changed the title
wingyplus
force-pushed
the
fix-utf-16-encoding
branch
from
32feee0 to
aa47ba4
Compare
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
wingyplus
force-pushed
the
fix-utf-16-encoding
branch
from
aa47ba4 to
0f4cc92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a quick prototype to fix #242. It seems that
advanceneeds to be converted to UTF-16 as per the position encoding LSP spec. The code needs to fix the code_mod_case.ex in theapply_editsfunction to convert it back to UTF-8 as well.