Skip to content

PromQL: throw validation error in PromqlCommand on instant queries #139810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sidosera wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PromQL: throw validation error in PromqlCommand on instant queries #139810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...in/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/promql/PromqlCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,10 @@ public String nodeString() {
@Override
public void postAnalysisVerification(Failures failures) {
LogicalPlan p = promqlPlan();
if (isInstantQuery()) {
failures.add(fail(p, "instant queries are not supported at this time [{}]", sourceText()));
return;
}
if (p instanceof AcrossSeriesAggregate == false) {
failures.add(fail(p, "only aggregations across timeseries are supported at this time (found [{}])", p.sourceText()));
}
Expand Down
7 changes: 7 additions & 0 deletions .../esql/src/test/java/org/elasticsearch/xpack/esql/analysis/promql/PromqlVerifierTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ public void testPromqlMissingAcrossSeriesAggregation() {
);
}

public void testPromqlInstantQuery() {
assertThat(
error("PROMQL index=test time=\"2025-10-31T00:00:00Z\" (avg(foo))", tsdb),
equalTo("1:48: instant queries are not supported at this time [PROMQL index=test time=\"2025-10-31T00:00:00Z\" (avg(foo))]")
);
}

public void testPromqlStepAndRangeMisaligned() {
assertThat(
error("""
Expand Down