Skip to content

Test data selector resolution #139794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
idegtiarenko wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −0
Open

Test data selector resolution #139794

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8d41d5
Test data selector resolution
idegtiarenko Dec 19, 2025
8dc48f4
add negative test cases
idegtiarenko Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...l/src/internalClusterTest/java/org/elasticsearch/xpack/esql/plugin/IndexResolutionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,19 @@ public void testResolvesDataStream() {
try (var response = run(syncEsqlQueryRequest("FROM data-stream-1"))) {
assertOk(response);
}
try (var response = run(syncEsqlQueryRequest("FROM data-stream-1::data"))) {
Copy link
Contributor

@luigidellaquila luigidellaquila Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be applied to all kinds of indices?
In case, maybe we can randomize some of our existing tests (conditionally adding ::data), that already validate the query output.

Copy link
Contributor Author

@idegtiarenko idegtiarenko Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only be applicable to data streams. The rest should result in not found. I should probably add some cases for that

assertOk(response);
}
expectThrows(
org.elasticsearch.xpack.esql.parser.ParsingException.class,
containsString("Invalid index name [data-stream-1::fake]"),
() -> run(syncEsqlQueryRequest("FROM data-stream-1::fake"))
);
expectThrows(
VerificationException.class,
containsString("Unknown index [no-such-data-stream::data]"),
() -> run(syncEsqlQueryRequest("FROM no-such-data-stream::data"))
);
}

public void testResolvesPattern() {
Expand Down