[ML] Basic CPS Support for ML Datafeeds #139781
Draft
+483
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for Cross-Project Search (CPS) in the Datafeed configuration. Key changes include: - Updated `PutDatafeedAction` and `UpdateDatafeedAction` to accept a new parameter for enabling CPS during request parsing. - Enhanced `DatafeedConfig` to handle CPS options, including serialization and deserialization of the `resolve_cross_project_index_expression` field. - Added integration tests to validate CPS functionality in datafeeds, ensuring that CPS-enabled indices can be created and retrieved correctly. - Adjusted existing tests to reflect the new CPS capabilities and removed restrictions that previously prevented CPS usage in datafeeds. These changes facilitate the use of CPS in machine learning datafeeds, allowing for more flexible data retrieval across projects.
…enhancement/cps-datafeeds-1
elasticsearchmachine
added
needs:triage
valeriy42
added
>enhancement
:ml
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
|
Hi @valeriy42, I've created a changelog YAML for you. |
This commit refactors the `PutDatafeedAction` and `UpdateDatafeedAction` classes to leverage a new method in `DatafeedConfig` for managing Cross-Project Search (CPS) settings. Key changes include: - Replaced inline CPS handling logic with a call to `DatafeedConfig.ensureCrossProjectSearchEnabled`, simplifying the code and improving maintainability. - Updated the `DatafeedUpdate` parser to correctly handle the `resolve_cross_project_index_expression` field during deserialization. - Added tests to ensure that CPS options are correctly applied and serialized. These changes enhance the clarity and efficiency of CPS management within datafeed actions, supporting better integration of cross-project capabilities in machine learning workflows.
…riy42/elasticsearch into enhancement/cps-datafeeds-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable ML datafeeds to search across multiple projects with unqualified index patterns by removing the artificial CPS block and integrating CPS mode detection. Since datafeeds already support CCS remote indices and
RemoteClusterAware.isRemoteIndexName()returnstruefor both CCS (cluster:index) and CPS (project:index) patterns, existing remote-handling code already works for CPS.