-
Notifications
You must be signed in to change notification settings - Fork 190
[Security][Cases][9.3 & Serverless]: Search bar in case attachment tab #4367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Vale Linting ResultsNo issues found on modified lines! |
mdbirnstiehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few little things that you may or may not want to change! Otherwise, LGTM!
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
|
Hi @nastasha-solomon, I'm doing a review and I just noticed this set of duplicate notes on this preview page: https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/4367/explore-analyze/alerts-cases/cases/manage-cases#add-case-files
|
melissaburpo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good; I only saw the one small duplicate note issue (link to comment), but other than that, this looks good to go
|
Agh, cursed snippets! |
benironside
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the IA updates, new section looks great 🤝

Summary
Fixes #4330 by adding a tip to the case docs that explains what can be searched from the Attachments tab. The actual updates are linked below:
This PR also makes a few organizational and structural improvements to case docs. More specifically, it:
Generative AI disclosure