Add macOS CI workflow #95

wdconinc · 2025-12-18T22:30:05Z

This PR adds a GitHub Actions workflow to build the ci environment on macOS.

Features

Uses spack/setup-spack@v2.1.1 for Spack installation
Uses spack/github-actions-buildcache@v2 for build cache management
Matrix strategy testing both GCC and Clang compilers
Automatic buildcache push/pull for faster rebuilds
Uploads environment graph as artifact for inspection

Testing

The workflow will run automatically on this PR to validate the macOS build.

…s-buildcache This workflow builds the ci environment on macOS using: - spack/setup-spack@v2.1.1 for Spack installation - spack/github-actions-buildcache@v2 for build cache management - Matrix strategy for both gcc and clang compilers - Automatic buildcache push/pull for faster rebuilds

wdconinc · 2025-12-18T22:31:49Z

.github/workflows/macos-ci.yml

+      - name: Setup Spack
+        uses: spack/setup-spack@v2.1.1
+        with:
+          ref: develop


@copilot Use the same spack version (and spack-packages version) that is used in the container build in this repository.

wdconinc · 2025-12-18T22:32:12Z

.github/workflows/macos-ci.yml

+        with:
+          ref: develop
+          color: true
+          path: ${{ github.workspace }}/spack


@copilot Apply the same cherry-picks that are used in the container build in this repository.

wdconinc · 2025-12-18T22:32:53Z

.github/workflows/macos-ci.yml

+          spack -e ci compiler find
+          spack -e ci external find --not-buildable cmake


@copilot Use the same compiler and external package finding strategy as used in the container build in this repository.

wdconinc · 2025-12-18T22:33:33Z

.github/workflows/macos-ci.yml

+      - name: Setup buildcache access
+        uses: spack/github-actions-buildcache@v2
+        with:
+          mode: readwrite
+          key: macos-${{ matrix.compiler }}-ci


@copilot Use the same buildcache as used in the container build in this repository.

wdconinc · 2025-12-18T22:33:59Z

.github/workflows/macos-ci.yml

+      - name: Show environment info
+        if: always()
+        run: |
+          spack -e ci find -lv
+          spack -e ci graph --dot > ci-graph.dot
+
+      - name: Upload environment graph
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: ci-environment-graph-${{ matrix.compiler }}
+          path: ci-graph.dot


@copilot Ditch the environment graph.

Copilot · 2025-12-18T22:34:12Z

@wdconinc I've opened a new pull request, #96, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

This PR introduces a GitHub Actions workflow to build and test the ci Spack environment on macOS platforms, expanding CI coverage beyond the existing Linux-based workflows.

Key Changes:

Adds macOS CI workflow with GCC and Clang compiler matrix testing
Integrates Spack buildcache management for faster rebuilds
Includes environment graph artifact generation for inspection

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-18T22:39:35Z

.github/workflows/macos-ci.yml

+        uses: actions/checkout@v4
+        with:
+          submodules: recursive
+


There is trailing whitespace at the end of this line. This should be removed to maintain consistent formatting.

Suggested change

Copilot · 2025-12-18T22:39:35Z

.github/workflows/macos-ci.yml

+          ref: develop
+          color: true
+          path: ${{ github.workspace }}/spack
+


There is trailing whitespace at the end of this line. This should be removed to maintain consistent formatting.

Suggested change

Copilot · 2025-12-18T22:39:36Z

.github/workflows/macos-ci.yml

+          spack env activate ci
+          spack -e ci compiler find
+          spack -e ci external find --not-buildable cmake
+


There is trailing whitespace at the end of this line. This should be removed to maintain consistent formatting.

Suggested change

Copilot · 2025-12-18T22:39:36Z

.github/workflows/macos-ci.yml

+        with:
+          mode: readwrite
+          key: macos-${{ matrix.compiler }}-ci
+


There is trailing whitespace at the end of this line. This should be removed to maintain consistent formatting.

Suggested change

Copilot · 2025-12-18T22:39:36Z

.github/workflows/macos-ci.yml

+      - name: Add Spack environment
+        run: |
+          spack env create ci spack-environment/ci
+          spack env activate ci


The workflow activates the Spack environment with "spack env activate ci" but doesn't persist the activation for subsequent steps. Each "run" step in GitHub Actions starts a new shell session. The activation command needs to be repeated in each step that uses the environment, or use "spack -e ci" consistently as done in later steps.

Copilot · 2025-12-18T22:39:38Z

.github/workflows/macos-ci.yml

+          spack env create ci spack-environment/ci
+          spack env activate ci
+          spack -e ci compiler find
+          spack -e ci external find --not-buildable cmake


Using --not-buildable with external find for cmake means that if cmake is not found externally, the build will fail. Consider whether this is intentional or if cmake should be allowed to be built by Spack as a fallback.

Suggested change

spack -e ci external find --not-buildable cmake

spack -e ci external find cmake

Copilot · 2025-12-18T22:39:38Z

.github/workflows/macos-ci.yml

+      - name: Push to buildcache
+        if: always()
+        run: |
+          spack -e ci buildcache push --update-index --only=package --unsigned ${{ github.workspace }}/buildcache-macos


The buildcache push command references a local directory path using github.workspace, but the github-actions-buildcache action at line 54 is configured with mode: readwrite and a key, which suggests it uses GitHub's cache. The push command should reference the buildcache location configured by the action, or the workflow should be updated to ensure consistency between the buildcache setup and push operations.

Suggested change

spack -e ci buildcache push --update-index --only=package --unsigned ${{ github.workspace }}/buildcache-macos

spack -e ci buildcache push --update-index --only=package --unsigned

Copilot · 2025-12-18T22:39:38Z

.github/workflows/macos-ci.yml

+    strategy:
+      fail-fast: false
+      matrix:
+        compiler: [gcc, clang]


The compiler matrix variable is defined but never used in the workflow. The Spack compiler configuration relies on "spack -e ci compiler find" which will auto-detect available compilers. To properly test with different compilers as intended by the matrix strategy, the workflow should specify which compiler to use, likely through Spack's spec syntax or compiler configuration.

Copilot · 2025-12-18T22:39:38Z

.github/workflows/macos-ci.yml

+
+jobs:
+  build:
+    runs-on: macos-latest


The workflow specifies "macos-latest" but doesn't consider that different macOS versions may have different default compilers and system libraries. For a more robust CI setup, consider pinning to specific macOS versions (e.g., macos-13, macos-14) or documenting which version is expected, especially since the compiler matrix suggests compiler-specific testing.

Suggested change

runs-on: macos-latest

runs-on: macos-13

Copilot · 2025-12-18T22:39:39Z

.github/workflows/macos-ci.yml

+      fail-fast: false
+      matrix:
+        compiler: [gcc, clang]
+


There is trailing whitespace at the end of this line. This should be removed to maintain consistent formatting.

Suggested change

…96) * Initial plan * Align macOS CI with container build: spack versions, cherry-picks, externals, and buildcache Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com> * Derive spack configuration from spack.sh and spack-packages.sh at runtime Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com> * Fix cherry-pick loops to filter heredoc delimiters and empty lines Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com> * Improve cherry-pick filtering and add proper quoting for security Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>

Copilot AI review requested due to automatic review settings December 18, 2025 22:30

wdconinc commented Dec 18, 2025

View reviewed changes

Copilot AI mentioned this pull request Dec 18, 2025

Align macOS CI with container build: derive configuration at runtime #96

Merged

Copilot started reviewing on behalf of wdconinc December 18, 2025 22:35 View session

Copilot AI reviewed Dec 18, 2025

View reviewed changes

		spack -e ci compiler find
		spack -e ci external find --not-buildable cmake

	spack -e ci external find --not-buildable cmake
	spack -e ci external find cmake

	spack -e ci buildcache push --update-index --only=package --unsigned ${{ github.workspace }}/buildcache-macos
	spack -e ci buildcache push --update-index --only=package --unsigned

Add macOS CI workflow #95

Are you sure you want to change the base?

Add macOS CI workflow #95

Uh oh!

Conversation

wdconinc commented Dec 18, 2025

Features

Testing

Uh oh!

wdconinc Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

wdconinc Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

wdconinc Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

wdconinc Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

wdconinc Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Dec 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants