[PLANPRO-5832] Signal ausleger with foundation #2047
+42
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Signals are now shown as Ausleger. It still looks wrong, but I think thats for a different ticket. 7707 and 7705 A95E3164-CDA3-47A5-963E-77A8B6BE1AAF: |
...et.feature.siteplan/src/org/eclipse/set/feature/siteplan/transform/SignalTransformator.xtend
Outdated
Show resolved
Hide resolved
TruongQuangSB
requested changes
Dec 8, 2025
...et.feature.siteplan/src/org/eclipse/set/feature/siteplan/transform/SignalTransformator.xtend
Outdated
Show resolved
Hide resolved
Comment on lines
+109
to
+110
| case FeatureType.Flash: | ||
| return FeatureLayerType.Flash |
Contributor
There was a problem hiding this comment.
no need to add the Flash feature here. By start this Layer haven't any feature
Comment on lines
+199
to
+200
| case FeatureType.Flash: | ||
| return 'Flash' // TODO |
Contributor
There was a problem hiding this comment.
Same here, the flash layer shouldn`t avaible at the select layer side panel
| <circle r="10" cx="35" cy="20"/> | ||
| <circle r="10" cx="5" cy="40"/> | ||
| <toolbox:anchor id="mastAnkerTop" x="20" y="40" /> | ||
| <toolbox:anchor id="mastAnkerBottom" x="20" y="20"/> |
Contributor
There was a problem hiding this comment.
actually the ``Vr1` haven't no anchor punkt, because the signal mast should be through between two circle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.