Skip to content

Fix colWidth calculation issue #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amytych wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix colWidth calculation issue #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d369267
Fix colWidth calculation issue
amytych Mar 2, 2019
7824041
Replace Math.floor with more fine grained approach
amytych Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,27 @@ class MagicGrid {
* @private
*/
colWidth () {
return this.items[0].getBoundingClientRect().width + this.gutter;
const width = this.container.getBoundingClientRect().width
let colWidth = this.items[0].getBoundingClientRect().width + this.gutter
let numCols = Math.floor(width / colWidth) || 1

// if we're dealing with subpixel rounding issue
// reduce the colWidth until we have a proper layout
// we know we should be able to fit one more column
// limit number of iterations to minimise overhead
// and to prevent any risk of infinite loop
if (Math.floor(colWidth) === Math.floor(width % colWidth)) {
const properNumCols = numCols + 1
let iterationCount = 0
const maxIterations = 20
while (numCols !== properNumCols && iterationCount < maxIterations) {
iterationCount += 1
colWidth -= 0.0001
numCols = Math.floor(width / colWidth)
}
}

return colWidth
}

/**
Expand Down