Allow syncBarcodeView consumers to define minimum scanning area #7356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisBarreiro
changed the title
CrisBarreiro
commented
Dec 15, 2025
| } | ||
|
|
||
| private fun setupExpandedScanningArea() { | ||
| if (minScanningAreaHeight == MIN_SCANNING_AREA_HEIGHT_NOT_SET) return |
Contributor
Author
There was a problem hiding this comment.
If RC flag is off, minScanningAreaHeight will be equal to MIN_SCANNING_AREA_HEIGHT_NOT_SET, so I don't think we need to feature flag here as well
CrisBarreiro
commented
Dec 15, 2025
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
|
|
||
| binding = if (syncFeature.useNewActivityConnectSyncLayout().isEnabled()) { |
Contributor
Author
There was a problem hiding this comment.
Alternatively, we could duplicate the entire activity and navigate to one or the other based on RC if we think that's safer
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sync/sync-impl/src/main/java/com/duckduckgo/sync/impl/ui/qrcode/SyncBarcodeView.kt
Outdated
Show resolved
Hide resolved
CrisBarreiro
force-pushed
the
feature/cris/dynamic-scanning-area
branch
from
eaeb280 to
1d9fa71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1212227266948491/task/1210351397656377?focus=true
Description
Allow syncBarcodeView consumers to define minimum scanning area
Use remote config to allow for synamic resizing of SyncBarcodeView along with minimum scanning area
Steps to test this PR
Feature 1
useNewActivityConnectSyncLayoutenabled (default state), open sync settings and try to add a new deviceFeature 2
useNewActivityConnectSyncLayout, open sync settings and try to add a new deviceUI changes
Note
Adds a remote-toggle new Connect Sync layout and enables
SyncBarcodeViewconsumers to set a minimum scanning area via a new attribute.SyncFeature.useNewActivityConnectSyncLayoutto switch between old/new Connect Sync UI.SyncConnectActivityselects layout at runtime and abstracts bindings viaConnectSyncBinding(old/new).res/layout/activity_connect_sync_new.xmlwith dynamic scanner area and updated QR/code UI.SyncBarcodeView)app:minScanningAreaHeightattribute (declared inattrs-sync-barcode-view.xml).view_square_decorated_barcode.xmlto wrapBarcodeViewinbarcodeContainer.Written by Cursor Bugbot for commit 1d9fa71. This will update automatically on new commits. Configure here.