Fix text shadow cutoff on android #126
Merged
+194
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insacc
force-pushed
the
fix/text-shadow-android-cutoff
branch
from
e10841c to
11ead1c
Compare
Attemp to fix text shadow cutoff Update the text shadow on android to prevent cutoff Expand the shadow on if padding is provided Add the missing import Add some logging Make shadow span use padding Attempt to fix text shadow cutoff on android Another attempt at fixing the text shadow cutoff Another attempt at fixing the text shadow cutoff issue on Android. Add more logging Add more logs Add more and more logs Implement shadow offset compensation in ReactTextView Make sure to keep the text position stable when the shadow is added. Update linear gradient span to match iOS behavior. Address gradient issues Another attempt to fix the text stroke width Revert some of the gradient changes Update shader mode Update the implementation once more Revert to width expansion approach - shadow cutoff confirmed without it Add more logging to the ReactTextView Remove debug logging Remove remaining debug logs from text rendering files Remove unused padding parameters from ShadowStyleSpan - Remove padding constructor parameters that were never used in getSize() or draw() - Remove updatePadding() method that was never called - Remove padding retrieval code from ReactBaseTextShadowNode - Both old and new architectures now consistently use 4-parameter constructor Align new arch (Fabric) shadow handling with old arch (Paper) - Remove shadowTopOffset from PreparedLayoutTextView - Vertical shadow space is already handled via font metrics adjustment - Both architectures now only compensate horizontally - Matches old arch behavior and comment: 'vertical doesn't need compensation' Remove unused getShadowDy() method and min import - getShadowDy() was only used for vertical compensation which we removed - kotlin.math.min import is not used anywhere in the file
insacc
force-pushed
the
fix/text-shadow-android-cutoff
branch
from
ff956d7 to
9a5ad54
Compare
insacc
changed the title
Flewp
reviewed
Dec 8, 2025
Flewp
left a comment
Flewp
left a comment
There was a problem hiding this comment.
Unless we plan on upstreaming this functionality to react-native, I would suggest putting as much of this feature code as possible internally. For example, making ShadowStyleSpan an open class and implementing our own internally, or providing callbacks to shim logic in the fork where the actual business logic exists internally.
These kinds of changes, especially feature + followup style, cause non-trivial overhead when we're trying to bump React Native versions and reapply every single change on top of the new version. They also destabilize features like this over time - if upstream makes API changes or migrates files from Java to Kotlin (I see ReactTextView is still Java), these merges can be error prone.
All being said, if you need to merge as is, go for it. But it would be valuable to refactor to minimize our changes to react native as a fast follow.
…yleSpan These getters are not used anywhere in the codebase. Only getShadowRadius() and getShadowDx() are used by getShadowAdjustment().
Flewp
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
-Changes the shadow style span from a CharacterStyle to a
ReplacementSpanin order the fix the issue on android where the shadow is cut off even with added padding as the characterStyle doesnt account for the shadow.This accounts for the shadow but also moves the text back to its original position so on the UI there wouldn't be any shifts when the shadow is applied.
Updates the gradient span to make sure that it matches the ios implementation
Updates the strokeWidth for the text stroke span to make sure that it matches the ios implementation
Test Plan: