Isolate parsing/serialising NQuads and canonicalisation algorithms in indivual modules #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mielvds
force-pushed
the
code-improvements
branch
2 times, most recently
from
9fd53c5 to
013c3ad
Compare
mielvds
force-pushed
the
220-rdf-canon
branch
from
0b57725 to
f1ed896
Compare
anatoly-scherbakov
approved these changes
Dec 17, 2025
davidlehn
reviewed
Dec 18, 2025
Member
davidlehn
left a comment
davidlehn
left a comment
There was a problem hiding this comment.
- Might have been better to do the cause commit as another PR, but that's fine.
- Needs changelog entries for the breaking (I assume) cause API change and nquads API change.
mielvds
force-pushed
the
220-rdf-canon
branch
from
fa8e50b to
eca2e2d
Compare
mielvds
force-pushed
the
220-rdf-canon
branch
from
eca2e2d to
b26bb90
Compare
Collaborator
Author
|
You're right @davidlehn, I split off the exception chaining in #224. The nquads API doesn't change because I kept the methods. For the canon and IdentifierIssuer, I added entries to the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the canonicalization algorithms, the nquads parsing and the
IdentifierIssuerin a separate modules. This is the first step of eventually moving the canonicalization algorithms out of this library.Because it no longer makes sense that an nquad parser or canonicalization algorithm raises JSON-LD errors, they have their own neutral
UnknownFormatErrorandParserError.