Dockerfile: add git repo and copy with --link #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put the force-udf layer first since that does not change frequently, and add the repository directly so the Docker cache can be used to speed up the image build.
The non-default Docker builders can fail with some incomprehensible message about index out of bounds when they fail to resolve user names. Use the numerical UID/GID for now to avoid that problem.
This puts the updates from the copy in a separate layer, which is what one wants usually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the force-udf layer first since
that does not change frequently,
and add the repository directly
so the Docker cache can be used
to speed up the image build.
Also switch to using --link and numerical
UID/GID when copying, the first to get
the reasonable behavior from COPY,
and the second to avoid strange out
of bounds messages for people who
build the Force image with a non-default
Docker builder.