Updated tracking / transitions of the task's version state. #9127
+79
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isoos
force-pushed
the
task-version-state
branch
from
b9c6f9e to
01d362e
Compare
jonasfj
reviewed
Dec 17, 2025
| // suppose to run on the instance we just failed to create. | ||
| // If this doesn't work, we'll eventually retry. Hence, correctness | ||
| // does not hinge on this transaction being successful. | ||
| await db.tasks.restorePreviousVersionsState( |
Member
There was a problem hiding this comment.
I'm pretty sure we shouldn't have a method for this, should be inline logic.
There is never a reason to call restorePreviousVersionsState from anywhere else is there?
Also you cannot look at restorePreviousVersionsState and not understand the context within which it belongs.
if we want it as a method, then it should be a helper method in this file, like updatePackageStateWithPendingVersions (which IMO could also be inline); but I do think updatePackageStateWithPendingVersions is a bit more specific in what it does and worth documenting separately. Also just to keep the code short.
Why can't we simply store previousScheduled as a local variable in scope of scheduleInstance?
isoos
force-pushed
the
task-version-state
branch
from
01d362e to
95fe45c
Compare
Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docsandpanaflags after scheduling (otherwise there is a time window where a new schedule has been started but not completed, where a previous run's results are not available).previousScheduledfield, but we could skip it and just useinitialTimestampwhen restoring the previous state.updatePackageStateWithPendingVersionsandrestorePreviousVersionsStatesince they no longer need to keep all the previous version state information.