#4134. Add new tests regarding whitespaces and interrupting lines #4135
Conversation
|
@szakarias @athomas please grant me the permission to assign reviewers. |
Done |
Thanks! |
sgrekhov
changed the title
|
@szakarias @eernstg please review. Some checks failed with |
|
I'll just remain aware of this work, perhaps adding a comment now and then, but not do regular full reviews. |
Co-authored-by: Erik Ernst <eernst@google.com>
szakarias
left a comment
szakarias
left a comment
There was a problem hiding this comment.
I suspect the SubprocessException is just a side effect of the analyzer failing (exit code 2) due to the warnings and infos. Please try addressing those 5 reported issues first to see if it clears up the CI.
It is indeed annoying, but you will need to comment out the unreachable code after markTestSkipped to resolve the dead_code warnings.
| @reflectiveTest | ||
| class LineBasedDocCommentsTest extends Co19TestBase { | ||
| /// Check that the parser removes the three slashes and all leading | ||
| /// whitespaces |
There was a problem hiding this comment.
nit: replace "whitespaces" with "whitespace" in general
4 participants
UPD.
The spec says "Exception: inside fenced code blocks (
```)...". Github flavored markdown also supports~~~as begin/end of code blocks. Probably it makes sense to mention it to the spec. Say "Exception: inside fenced code blocks (``` or ~~~)...".