Skip to content

Conversation

@alandefreitas
Copy link
Collaborator

@alandefreitas alandefreitas commented Dec 22, 2025

Add installGenerator() and findGenerator() functions to the public Generator.hpp header, allowing plugins to register custom generators without accessing internal implementation details.

  • Move Generators class to private GeneratorRegistry
  • Add thread-safe installGenerator() and findGenerator() functions
  • Add unit tests for the new public API

fix #313

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

🚧 Danger.js checks for MrDocs are experimental; expect some rough edges while we tune the rules.

✨ Highlights

  • 🧪 Existing golden tests changed (behavior likely shifted)

🧾 Changes by Scope

Scope Lines Δ Lines + Lines - Files Δ Files + Files ~ Files ↔ Files -
🥇 Golden Tests 7280 2430 4850 226 - 226 - -
🛠️ Source 154 111 43 8 - 5 3 -
🧪 Unit Tests 140 138 2 2 1 1 - -
📦 Other 61 61 - 1 1 - - -
⚙️ CI 15 - 15 1 - 1 - -
Total 7650 2740 4910 238 2 233 3 -

Legend: Files + (added), Files ~ (modified), Files ↔ (renamed), Files - (removed)

🔝 Top Files

  • test-files/golden-tests/symbols/record/class-template-specializations-1.html (Golden Tests): 1242 lines Δ (+414 / -828)
  • test-files/golden-tests/symbols/record/class-template-specializations-3.html (Golden Tests): 195 lines Δ (+65 / -130)
  • test-files/golden-tests/javadoc/ref/ref.html (Golden Tests): 162 lines Δ (+54 / -108)

Generated by 🚫 dangerJS against 02042a2

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 22, 2025

An automated preview of the documentation is available at https://1139.mrdocs.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-12-23 00:52:51 UTC

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 93.44262% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.18%. Comparing base (c85be75) to head (02042a2).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
src/test/lib/Support/Generator.cpp 92.68% 3 Missing ⚠️
src/lib/Support/GeneratorRegistryImpl.cpp 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1139      +/-   ##
===========================================
+ Coverage    86.17%   86.18%   +0.01%     
===========================================
  Files          322      323       +1     
  Lines        23906    23954      +48     
===========================================
+ Hits         20600    20645      +45     
- Misses        3306     3309       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alandefreitas
Copy link
Collaborator Author

image image

@mizvekov these are some other false positives I got. I also included the codecov configuration file in this pull request just to improve things a little bit in the meanwhile.

@alandefreitas alandefreitas merged commit 8da09e3 into cppalliance:develop Dec 23, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generators is private

2 participants