Skip to content

Conversation

@JqRrt
Copy link
Collaborator

@JqRrt JqRrt commented Dec 5, 2025

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@mocayo mocayo changed the title feat: trajectory observe [feat] [observation] trajectory observe Dec 5, 2025
@mocayo
Copy link
Collaborator

mocayo commented Dec 5, 2025

Submission history contains excessive meaningless information, please organize it

Copy link
Collaborator

@mocayo mocayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reorganize commit message and resolve conflicts

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 83.15018% with 138 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...bservability/domain/trace/service/trace_service.go 86.05% 16 Missing and 13 partials ⚠️
...bility/domain/trace/entity/loop_span/trajectory.go 89.39% 14 Missing and 14 partials ⚠️
backend/modules/observability/infra/repo/trace.go 63.63% 19 Missing and 1 partial ⚠️
...ility/domain/trace/service/trace_export_service.go 45.45% 15 Missing and 3 partials ⚠️
...api/handler/coze/loop/apis/eval_open_apiservice.go 0.00% 9 Missing ⚠️
...i/handler/coze/loop/apis/evaluation_set_service.go 0.00% 9 Missing ⚠️
...dler/coze/loop/apis/observability_trace_service.go 0.00% 6 Missing ⚠️
...vability/application/convertor/trace/trajectory.go 96.22% 2 Missing and 2 partials ⚠️
backend/modules/observability/application/trace.go 93.65% 2 Missing and 2 partials ⚠️
...domain/task/service/taskexe/tracehub/subscriber.go 0.00% 2 Missing and 1 partial ⚠️
... and 4 more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   69.88%   70.06%   +0.18%     
==========================================
  Files         588      590       +2     
  Lines       54452    55250     +798     
==========================================
+ Hits        38052    38712     +660     
- Misses      13525    13626     +101     
- Partials     2875     2912      +37     
Flag Coverage Δ
unittests 70.06% <83.15%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...bility/application/convertor/trace/trace_export.go 95.85% <100.00%> (+0.11%) ⬆️
.../modules/observability/domain/task/entity/event.go 58.13% <100.00%> (ø)
...dules/observability/domain/trace/entity/dataset.go 85.60% <100.00%> (+0.23%) ⬆️
...bservability/domain/trace/entity/loop_span/span.go 75.92% <100.00%> (+0.18%) ⬆️
...infra/mq/producer/span_with_annotation_producer.go 95.23% <100.00%> (ø)
...modules/evaluation/application/eval_openapi_app.go 91.50% <0.00%> (-0.30%) ⬇️
...dules/evaluation/application/evaluation_set_app.go 62.71% <0.00%> (-0.28%) ⬇️
.../observability/application/convertor/trace/span.go 86.55% <95.00%> (+1.70%) ⬆️
...vability/infra/rpc/evaluationset/evaluation_set.go 45.16% <33.33%> (-0.13%) ⬇️
...domain/task/service/taskexe/tracehub/subscriber.go 68.42% <0.00%> (-1.85%) ⬇️
... and 9 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5177532...2f90dfb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: Found compile-blocking issue in otel FieldConf map and a missing middleware function reference in router.

  • [🚫Must Fix] backend/modules/observability/lib/otel/otel_convert.go: Struct literal for FieldConf uses non-existent field names (attributeKey, isTag, dataType). Replace with AttributeKey, IsTag, DataType.
  • [🚨Should Fix] backend/api/router/coze/loop/apis/coze.loop.apis.go: Route references _gettrajectoryconfigMw but the stub is not defined in middleware.go. Add the missing middleware function.

Please address these to unblock compilation and ensure routing consistency.

@JqRrt JqRrt force-pushed the feat_trajectory_observe branch 7 times, most recently from 002b8ef to 1e3d78c Compare December 10, 2025 02:24
@JqRrt JqRrt force-pushed the feat_trajectory_observe branch from 09c998d to 2f90dfb Compare December 10, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants