explicitly use Range.new/3 when counting down #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
With recent versions of Elixir, a runtime warning comes up when using
first..lastnotation whenfirstis greater thanlast.Example:
This change simply uses the explicit Range.new/3 operator specifying -1 for the step.
Related doc:
https://hexdocs.pm/elixir/1.15.0/Range.html#new/2
Because of the simplicity and small size of this change, I thought it appropriate to merge into @nathany-copia 's excellent ongoing work to bring Timex up to date.