Fixed ignore_event_type logic. #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@andrew-deyoung welcome and thanks for contributing! @yehonatan-bauminger assigning to you for review. |
Author
|
This PR should also fix Issue #128 |
Author
|
Hey, just wondering when this PR might be reviewed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore_event_typewas omitting the Type field from the returned dictionary in some cases where it was required. Notably, ifignore_event_typewas false, Type would only be included if the Type started with "Event". This resulted in errors with the Control-M REST API.I did my best to guess what the logic should be based on the previous logic, but I'll update the PR if this is incorrect.
Additionally, I tidied the rest of the function somewhat. Notably:
popmethod instead of__delitem__"attributes_valid"