Remove deprecated mypy option #611
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* "no_strict_optional = true" has been deprecated by mypy. This change remove linting errors. Signed-off-by: Jhon Honce <jhonce@redhat.com>
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated no_strict_optional = true option from the mypy configuration in pyproject.toml. The option has been deprecated by mypy and its removal eliminates linting errors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
/packit rebuild-failed |
Contributor
|
I didn't find the deprecation notice but since "it's evil" let's remove it and work on fixing the type checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jhon Honce jhonce@redhat.com