Support push --all-tags to push all tags
#4627
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengyuZhu6
reviewed
Dec 8, 2025
Comment on lines
+126
to
+138
| var tagRefs []string | ||
| for _, img := range imgList { | ||
| if strings.HasPrefix(img.Name, repo+":") { | ||
| tagRefs = append(tagRefs, img.Name) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
The prefix matching is too broad and can match unintended images. For example, if repository is mytest , it will correctly match mytest:latest. But it will also incorrectly match mytestrepo:latest
Author
There was a problem hiding this comment.
If repo is mytest and img.Name is mytestrepo:latest, the strings would not match. The HasPrefix method would check if mytest: is a prefix of mytestrepo:latest, which is false.
| if err != nil { | ||
| return err | ||
| // Handle --all-tags | ||
| if options.AllTags { |
Member
There was a problem hiding this comment.
Currently, iff user runs nerdctl push myrepo:v1 --all-tags , the tag :v1 is silently ignored. It should return an error like docker does: https://github.com/docker/cli/blob/1a1a4fc478fcd0131f3f3225b98faa5bd16dc51e/cli/command/image/push.go#L102
Signed-off-by: Yash Kukrecha <ykukrecha@gmail.com>
yashkukrecha
force-pushed
the
support-push-all-tags
branch
from
e4b16ed to
9a3cfc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Docker-compatible --all-tags support and fixes a SOCI regression when pushing multiple tags of the same image.
Key changes:
--all-tagsflag forimage pushFixes #3751