Experiment with TypedDict in CWL types
#2192
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlassOfWhiskey
force-pushed
the
try-typed-dicts-from-cwl-utils
branch
9 times, most recently
from
614eb80 to
49df34f
Compare
mr-c
reviewed
Dec 15, 2025
mr-c
force-pushed
the
try-typed-dicts-from-cwl-utils
branch
from
023fe20 to
99d499e
Compare
This commit checks that the new `TypedDict` type aliases specified in cwl-utils with PR common-workflow-language/cwl-utils#393 do not break anything in the cwltool type system.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2192 +/- ##
==========================================
+ Coverage 84.96% 85.01% +0.04%
==========================================
Files 46 46
Lines 8455 8479 +24
Branches 1971 1972 +1
==========================================
+ Hits 7184 7208 +24
- Misses 803 804 +1
+ Partials 468 467 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mr-c
force-pushed
the
try-typed-dicts-from-cwl-utils
branch
from
2c31446 to
5e0586b
Compare
…ing.Lock until Python 3.13 python/cpython#114315 fixed in 3.13 python/cpython@d96358f
Yes, a bit odd that `class: Directory` objects in `listing` had a `dirname`, but we are temporarily using that (and fixing them) for setting the outdir when updating the Pathmapper. Then the `dirname` fields are removed immediately after.
mr-c
force-pushed
the
try-typed-dicts-from-cwl-utils
branch
from
5e0586b to
8920b7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit checks that the new
TypedDicttype aliases specified in cwl-utils with PR common-workflow-language/cwl-utils#393 do not break anything in the cwltool type system.