Skip to content

fix(dial): verify HTTP/1.x protocol in verifyServerResponseH1 #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mafredri wants to merge 1 commit into
base: mafredri/http2
Choose a base branch
from
+4 −0
Open

fix(dial): verify HTTP/1.x protocol in verifyServerResponseH1 #550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dial.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,10 @@ func verifyServerResponse(opts *DialOptions, copts *compressionOptions, secWebSo
}

func verifyServerResponseH1(opts *DialOptions, copts *compressionOptions, secWebSocketKey string, resp *http.Response) (*compressionOptions, error) {
if resp.ProtoMajor != 1 {
return nil, fmt.Errorf("expected HTTP/1.x response but got: %s", resp.Proto)
}

if resp.StatusCode != http.StatusSwitchingProtocols {
return nil, fmt.Errorf("expected handshake response status code %v but got %v", http.StatusSwitchingProtocols, resp.StatusCode)
}
Expand Down