feat: introduces an option for a custom body size in websocket.Dial function #548
+159
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Feature asked by this issue:
What
DialOptions.MaxErrorResponseBodyBytesso callers can opt into more (or zero) error-bodybytes when the handshake fails, enabling better branching on status/body while keeping the default
1024-byte limit.
still guards error-body reads; disabled option closes without reading.
Key Changes
still close original body with 3s fail-safe.
status code presence, and nil-body safety.
Testing
I did some testing with a dummy server responding a fixed status 400 and a 1mb body:
