🤖 fix: restore thinking level when model changes #1136
Merged
+272
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
ThinkingProvider was reading the model non-reactively, so when the model changed (e.g., via Cycle Model), the thinking level wasn't updated. Fix: Subscribe to model changes via usePersistedState with listener mode, so when the model changes, we derive the new thinking key and load the correct stored value for that model. --- _Generated with `mux` • Model: `anthropic:claude-sonnet-4-20250514` • Thinking: `low`_
ammar-agent
force-pushed
the
fix-thinking-model-sync
branch
2 times, most recently
from
c93df67 to
2ec9200
Compare
- Key ThinkingProviderInner by per-model thinking key to avoid one-render stale thinking state during model switches (e.g. Cycle Model) - Add regression test: switching models restores per-model thinking level
ammar-agent
force-pushed
the
fix-thinking-model-sync
branch
from
2ec9200 to
61e2a2d
Compare
- Rework usePersistedState to use React 18 useSyncExternalStore - Cache localStorage snapshots by raw string to prevent render loops - Remove ThinkingProvider remount workaround (prevents Review/diff refresh) - Add regression tests for model switching + no child remount --- _Generated with • Model: • Thinking: _
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix model-switch thinking level restore and stop Review/diff “refresh” behavior on Cycle Model.
Changes
usePersistedStateto use React 18useSyncExternalStore(stable localStorage-backed store)Risk
Medium:
usePersistedStateis a shared primitive. Mitigated by stable snapshot caching and added tests.Testing
make static-checkmake typecheckbun test src/browserGenerated with
mux• Model:anthropic:claude-sonnet-4-20250514• Thinking:low