-
Notifications
You must be signed in to change notification settings - Fork 0
Add execution durations to flow #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Maybe we should save the last x execution times for comparison? @raphael-goetz @Taucher2003 what do you think? |
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2222278893 Status: Failed Job summariesrspec: [ee]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12484566277/artifacts/tmp/coverage/index.html rspec: [ce]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12484566272/artifacts/tmp/coverage/index.html rubocop724 files inspected, no offenses detected |
|
|
||
| class AddLastExecutionDurationToFlows < Code0::ZeroTrack::Database::Migration[1.0] | ||
| def change | ||
| add_column :flows, :last_execution_duration, :bigint, null: true, default: nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A single field is not going to work for our requirements. We need to store each execution duration (well, more like a daily aggregate of all executions that day) and can't store only the last execution duration. This is going to be used for usage quotas, so we need to know how much time was used for a given time span.
We definitely also need to store the time in relation to the runtime because not every runtime is subject to usage quotas. Not sure if we need granularity for each flow or if we should limit the granularity to projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we should store every execution time of every flow? Or just in the last 14 days or so?
close #779