Skip to content

Conversation

@georgeh0
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up unnecessary type checking suppressions now that the mypy configuration has been properly tuned. The main change is updating the mypy config to handle untyped decorators, which allows removal of many type ignore comments throughout the codebase.

  • Updated mypy configuration to disable "untyped-decorator" errors for examples
  • Removed unnecessary # type: ignore comments from import statements and return statements
  • Removed unnecessary cast() calls and their corresponding imports from the typing module

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Updated mypy error suppression list to include "untyped-decorator" for handling decorator-related type issues
python/cocoindex/functions/colpali.py Removed # type: ignore[import-untyped] comment from colpali_engine import
examples/postgres_source/main.py Removed type ignore comments from pgvector import and fetchall() return
examples/pdf_embedding/main.py Removed type ignore comment from text_from_rendered return value
examples/pdf_elements_embedding/main.py Removed cast() calls and typing import for CLIP embedding functions
examples/patient_intake_extraction_dspy/main.py Removed type ignore comments from dspy class definitions and return statements
examples/paper_metadata/main.py Removed cast() call and typing import from pdf_to_markdown function
examples/manuals_llm_extraction/main.py Removed cast() call and typing import from text conversion
examples/image_search/main.py Removed type ignore comments from embedding returns and FastAPI decorator
examples/image_search/colpali_main.py Removed type ignore comment from FastAPI decorator
examples/fastapi_server_docker/main.py Removed type ignore comment from FastAPI decorator
examples/face_recognition/main.py Removed type ignore comment from face embedding return
examples/custom_output_files/main.py Removed type ignore comment from markdown render return

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@georgeh0 georgeh0 merged commit c3fc71d into main Dec 18, 2025
18 checks passed
@georgeh0 georgeh0 deleted the g/cleanup-type-ignore branch December 18, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants