Skip to content

Conversation

@jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Dec 8, 2025

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 10099ff
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/693c5cc59bc7c000084f5a6a

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 10099ff
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/693c5cc5c72e6a00086cef12

@netlify
Copy link

netlify bot commented Dec 8, 2025

Netlify Preview

Name Link
🔨 Latest commit 10099ff
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/693c5cc56b8e200008183de9
😎 Deploy Preview https://deploy-preview-21543--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jhlodin jhlodin force-pushed the jl/doc-15288 branch 2 times, most recently from 6f65125 to 84ae52c Compare December 8, 2025 21:52
Copy link
Contributor

@pritesh-lahoti pritesh-lahoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Thanks, @jhlodin !

Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Pritesh feedback

Refactor example and override doc to not require container field

Additional Pritesh feedback
@jhlodin jhlodin enabled auto-merge (squash) December 12, 2025 18:22
@jhlodin jhlodin merged commit 23e0fd4 into main Dec 12, 2025
6 checks passed
@jhlodin jhlodin deleted the jl/doc-15288 branch December 12, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants