Remorses update #15
Open
Remorses update #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the package can be used directly by any Next.js application, but if this package is used transitively (by a package which itself is used by the Next.js application) resolving the wasm file fails.
This happens because `new URL(".", import.meta.url)` is invalid. The first argument must be a file, not a directory.
allow package to be used with turborepo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very quick rebase of #13 to https://github.com/remorses/htmlrewriter to see how close this gets to a working update.
I haven't tested it thoroughly at all yet. Primary diff is the last commit (ba6ab50) after all the remorses patches.