Rename g4org::Options to orange::inp::OrangeGeoFromGeant

[sethrj]

This starts to address some of the discussion in #2045 (comment) by adding an orange/inp directory and renaming the G4->Orange conversion option struct. I will then add a celeritas::inp::OrangeGeo for runtime options (to be used for BIH, maximum intersections, etc.)

[github-actions]

Test summary

 5 742 files   9 228 suites   18m 41s ⏱️
 2 094 tests  2 068 ✅  26 💤 0 ❌
32 079 runs  31 931 ✅ 148 💤 0 ❌

Results for commit 2f86b29.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.93%. Comparing base (084a69a) to head (2f86b29).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2134   +/-   ##
========================================
  Coverage    84.92%   84.93%           
========================================
  Files         1273     1273           
  Lines        44666    44667    +1     
  Branches     16611    16523   -88     
========================================
+ Hits         37934    37936    +2     
  Misses        4749     4749           
+ Partials      1983     1982    -1     

Files with missing lines	Coverage Δ
src/orange/OrangeInput.hh	82.60% <ø> (ø)
src/orange/OrangeParams.cc	83.33% <100.00%> (ø)
src/orange/g4org/Converter.cc	84.72% <ø> (ø)
src/orange/g4org/PhysicalVolumeConverter.cc	86.79% <ø> (ø)
src/orange/g4org/ProtoConstructor.cc	94.57% <100.00%> (+0.03%)	⬆️
src/orange/g4org/ProtoConstructor.hh	100.00% <100.00%> (ø)
src/orange/g4org/Volume.hh	100.00% <ø> (ø)
src/orange/inp/IO.json.cc	100.00% <100.00%> (ø)
src/orange/inp/Import.hh	100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sethrj]

@stognini I'm now seeing warnings from ROOT:

[61/408] Generating CeleritasRootInter...ict.pcm, ../../lib/libceleritas.rootmap
Warning: Unused class rule: celeritas::MuonicMolecule

Could you fix in your next PR?

[sethrj]

@pcanal Is there a "Werror" flag that can be given to rootcling to help us catch warnings on the CI? ☝️

[pcanal]

Is there a "Werror" flag that can be given to rootcling to help us catch warnings on the CI?

The aptly named --failOnWarnings

[stognini]

Warning: Unused class rule: celeritas::MuonicMolecule

Yep, I noticed that as soon as I rebuilt from scratch this morning. Fixed it in the branch with the executor work, but I can also make a tiny PR just to fix this in the meantime, if you prefer.

[sethrj]

Sorry @pcanal and @stognini I posted those two on the wrong PR, meant to put it on #2125

[sethrj]

and an executor branch update is fine @stognini

[sethrj]

@elliottbiondo This small change is RTR

[pcanal]

@stognini I'm now seeing warnings from ROOT:

[61/408] Generating CeleritasRootInter...ict.pcm, ../../lib/libceleritas.rootmap
Warning: Unused class rule: celeritas::MuonicMolecule

Could you fix in your next PR?

This is fixed in #2145