Two small features added #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If '@' is pressed while still recording a macro, a warning is displayed and recording is stopped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Caleb, thank you for your package, I use it frequently. I'm simply using a pull request here just to send you this message, so no worries if you don't merge or even look at my changes.
As to the changes I made:
I've added a safety exit when you try to apply a macro while still in recording mode. It will simply not apply anything and take you out of recording mode first (as I feel that once you forget to leave recording mode your macro is unusable anyway and you'll have to start over).
I've felt that an append function would be neat. There are two versions as I felt some people will want a pure append mode like in Vim (Q), but that may become confusing because it lets you add your moves with no regard to what the current macro does. So I've added 'apply then append' mode (g @) which may be more intuitive for some as you can run your macro, see what it did, then add your changes from there.
I'm not a pro coder so if you feel that I wrote some bad code or messed up yours I apologize in advance!
Thank you again for this package,
Seb