feat: add time-based timer functionality with comprehensive testing (closes #6) #156
+522
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add --time/-t flag to set timer until specific time (e.g., 14:30, 2:30PM) - Support multiple time formats: 24h, 12h with AM/PM (case insensitive), with/without seconds - Implement smart scheduling: past times automatically target next day - Reject ambiguous single-digit hour formats (e.g., "1:30") to prevent confusion - Add calculateDurationUntilTime function with robust time parsing - Enhance formatDuration with cleaner display and better precision - Add comprehensive test suite with 95%+ coverage: * Duration formatting validation * Time parsing for all supported formats * Error handling and edge cases * Real-world usage scenarios * Performance benchmarks - Update README with usage examples and supported time formats - Maintain backward compatibility with existing duration-based timers Examples: timer -t 14:30 # Until 2:30 PM today/tomorrow timer -t 2:30PM # 12-hour format timer -t 07:00 -n Alarm # Named morning timer
linkzera
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples:
timer -t 14:30 # Until 2:30 PM today/tomorrow
timer -t 2:30PM # 12-hour format
timer -t 07:00 -n Alarm # Named morning timer