Adjust variable context to pass lezer-feel custom context tests #62
+70
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the context did not properly account for certain edge cases, in the process failing four lezer-feel parse tests, around: * context merging * evaluation of lazy values This fixes the issue, aligns the context (verbatim copy) with what is tested as part of lezer-feel (`custom-context`).
nikku
force-pushed
the
align-custom-context
branch
from
3e143e7 to
0d61116
Compare
nikku
added
backlog
bpmn-io-tasks
bot
added
needs review
nikku
changed the title
nikku
changed the title
nikku
force-pushed
the
align-custom-context
branch
from
3ec866f to
0d61116
Compare
nikku
requested review from
a team,
Buckwich and
philippfromme
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Previously the context did not properly account for certain edge cases, in the process failing four lezer-feel parse tests, around:
This fixes the issue, aligns the context (verbatim copy) with what is tested as part of lezer-feel (
custom-context).Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool