cli: Extend bootc container inspect with kernel info
#1873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/install
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request extends bootc container inspect to include kernel information, which is a useful addition for tooling. The implementation involves refactoring UKI detection logic into a new kernel module, which improves code organization and modularity. The changes are well-tested, including integration tests for the new output fields, and the documentation has been updated accordingly. Overall, this is a solid contribution. I have a couple of minor suggestions for the new kernel module to improve robustness and make the code more idiomatic.
The container-inspect command previously only reported kernel arguments. Extend it to also report kernel information, including whether the image contains a traditional kernel or a Unified Kernel Image (UKI). This consolidates UKI detection logic previously in bootc_composefs::boot into a new kernel module that can find kernels via either the traditional /usr/lib/modules/<version>/vmlinuz path or UKI files in /boot/EFI/Linux/. The ContainerInspect output now includes a "kernel" field with version and unified (boolean) properties, enabling tooling to determine the boot method before installation. Assisted-by: OpenCode (Claude Opus 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
container-inspect-uki
branch
2 times, most recently
from
4674ded to
b62a648
Compare
Contributor
|
Failures seem valid: |
The container inspect command previously only supported JSON output. This extends it to support human-readable output (now the default) and YAML, matching the output format options available in other bootc commands like status. The --json flag provides backward compatibility for scripts that expect JSON output, while --format allows explicit selection of any supported format. Assisted-by: OpenCode (Sonnet 4) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
container-inspect-uki
branch
from
b62a648 to
0428ac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The container-inspect command previously only reported kernel arguments. Extend it to also report kernel information, including whether the image contains a traditional kernel or a Unified Kernel Image (UKI).
This consolidates UKI detection logic previously in bootc_composefs::boot into a new kernel module that can find kernels via either the traditional /usr/lib/modules//vmlinuz path or UKI files in /boot/EFI/Linux/.
The ContainerInspect output now includes a "kernel" field with version and unified (boolean) properties, enabling tooling to determine the boot method before installation.
Assisted-by: OpenCode (Claude Opus 4.5)