Add NonZeroSign type to ensure proper sign handling #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Dec 16, 2025
Contributor
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
Looks mostly correct! Worth running through test262 but is probably fine.
src/builtins/core/zoned_date_time.rs
Outdated
| } else { | ||
| Sign::Positive | ||
| }; | ||
| let sign = Sign::from( |
Contributor
There was a problem hiding this comment.
nit: why not NonZeroSign::from?
Member
Author
There was a problem hiding this comment.
I can add it in. The main reason was because I was a bit over cautious about adding in an extra from implementation. Wait, actually this is a good question.
Contributor
There was a problem hiding this comment.
Yeah I think an extra From impl is fine.
Manishearth
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
NonZeroSigntype tolib.rsand makes appropriate adjustments for the new type.Open question is with a
SignandNonZeroSigntype now in temporal_rs. Should we move them to their ownsignmodule or keep them in the crate root?