Skip to content

Conversation

@benoitlx
Copy link
Owner

@benoitlx benoitlx commented Feb 2, 2025

I'm trying to do too much with these changes. This is why it's only a draft.
A rewrite will be completed in this branch

Problematic elements

  • Trying to do the job of a parser
    • comparing labels in order to prevent multiple definition
    • aggregating identifier and value for the DEFINE variant
  • Error management is painful : lot of boilerplate in lexer_error.rs
    • need to use macro in order to reduce boilerplate
    • need to flatten enums instead of separate struct
  • Callback functions for Token should be within impl Token {}
  • There should be less variant for Token (e.g. one Register(Reg) variant instead of A, V, ...)

@benoitlx benoitlx added the wontfix This will not be worked on label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants