Vivek/deps to remove #3
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side of root as 3rd party
When using per-file generation mode, Gazelle was not correctly updating existing py_library targets that spanned multiple source files if those files were also processed individually. This change ensures that such existing targets are re-evaluated as a whole, allowing their dependencies to be correctly updated. The test case `per_file_respect_existing_multiple_srcs` now passes functionally (dependencies are added correctly). A remaining diff exists due to attribute reordering (tags vs deps) and srcs formatting, which is a common canonicalization effect and not a functional issue.
amartani
force-pushed
the
main-benchling
branch
from
a7fe7a6 to
38255c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Instructions/requirements
type: descriptionformat. See CONTRIBUTING.md for types.CHANGELOG.mdas applicablesection at the bottom.
See CONTRIBUTING.md for our breaking changes process.