Skip to content

Conversation

@ashishrp-aws
Copy link
Contributor

Problem

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ashishrp-aws and others added 2 commits November 18, 2025 15:43
* fix: fix to add the mcp command in logs

* fix: fix to add stderr logs
@ashishrp-aws ashishrp-aws requested a review from a team as a code owner November 20, 2025 05:23
…2511)

* fix: fix upgarde the lsp version to 1.47.0

* fix: fix to provide server error messages for removed errors

* revert: revert package-lock.json changes

* Revert "fix: fix upgarde the lsp version to 1.47.0"

This reverts commit 4086962.

* revert: revert for check interval

* fix: fix for failing unit tests
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 42.26631% with 3434 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.78%. Comparing base (30e28b7) to head (ca8aa64).
⚠️ Report is 34 commits behind head on feature/mcp-governance-dev.

Files with missing lines Patch % Lines
...anguage-server/netTransform/atxTransformHandler.ts 0.00% 1453 Missing ⚠️
...ge-server/agenticChat/tools/mcp/mcpEventHandler.ts 11.66% 356 Missing ⚠️
...rc/language-server/agenticChat/tools/toolServer.ts 0.00% 233 Missing ⚠️
...ed/amazonQServiceManager/AtxTokenServiceManager.ts 37.18% 223 Missing ⚠️
...ared/amazonQServiceManager/atxTransformProfiles.ts 0.00% 150 Missing ⚠️
...anguage-server/agenticChat/tools/mcp/mcpManager.ts 65.95% 142 Missing and 1 partial ⚠️
chat-client/src/client/mcpMynahUi.ts 42.66% 127 Missing and 2 partials ⚠️
...guage-server/netTransform/atxNetTransformServer.ts 0.00% 125 Missing ⚠️
...nguage-server/agenticChat/agenticChatController.ts 37.29% 115 Missing and 1 partial ⚠️
...erer/src/language-server/netTransform/atxModels.ts 0.00% 95 Missing ⚠️
... and 24 more
Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/mcp-governance-dev    #2510      +/-   ##
==============================================================
- Coverage                       62.51%   60.78%   -1.73%     
==============================================================
  Files                             266      280      +14     
  Lines                           60047    65578    +5531     
  Branches                         3863     4206     +343     
==============================================================
+ Hits                            37536    39860    +2324     
- Misses                          22435    25634    +3199     
- Partials                           76       84       +8     
Flag Coverage Δ
unittests 60.78% <42.26%> (-1.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ashishrp-aws and others added 25 commits November 20, 2025 15:49
* feat: add MCP registry service and validator for governance (#2433)

* feat: add MCP registry service and validator for governance

* fix: fix for unit tests

* fix: fix for using httpUtils with proxy agent

* feat: add MCP registry validation and server config conversion (#2440)

* feat: add MCP registry validation and server config conversion

* fix: fix for mcpManager failures

* feat: implement MCP registry service with validation, error handling, and synchronization (#2443)

* feat(amazonq): add MCP registry sync, enterprise validation. (#2450)

* feat(amazonq): add MCP registry sync, enterprise validation, ACG support, version caching

* fix: fix for test failures

* fix: removed Agentcore check

* feat: add OCI registry support, improve MCP initialization flow (#2465)

* feat: add OCI registry support, improve MCP initialization flow, and enhance registry validation

* fix: fix for failing tests

* fix: fix to make registryActive non-optional

* fix(amazonq): separate server discovery from init (#2480)

* fix(amazonq): separate server discovery from init and improve error handling

* fix: update package-lock.json

* fix: fix for delete, save and cancel buttons for registry mcps

* fix: fix to add addiotnal header and variables to registry mcps

* fix: fix for failing registryUrl tests

* fix: move OCI environment variables to config.env and correct mcpRegistryUrl property name (#2486)

* fix: fix for arguments for local docker mcp servers (#2489)

* fix: fix for env variables for local docker mcp servers

* fix: imporve readability for oci check

* feat: add Docker env var support and enable timeout config for MCP (#2494)

* feat: add Docker env var support and enable timeout config for MCP registry servers

* fix: fix for unit tests

* fix: fix for compilation failure

* fix(amazonq): fix for server refresh

* fix: fix for server refresh

* fix: fix for server init

* fix: fix to add the mcp command in logs (#2499)

* fix: fix to add the mcp command in logs

* fix: fix to add stderr logs

* fix: fix to provide error messages for removed errors from registry (#2511)

* fix: fix upgarde the lsp version to 1.47.0

* fix: fix to provide server error messages for removed errors

* revert: revert package-lock.json changes

* Revert "fix: fix upgarde the lsp version to 1.47.0"

This reverts commit 4086962.

* revert: revert for check interval

* fix: fix for failing unit tests

---------

Co-authored-by: aws-toolkit-automation <43144436+aws-toolkit-automation@users.noreply.github.com>
Co-authored-by: Richard Li <742829+rli@users.noreply.github.com>
* chore(release): release packages from branch main

* fix: fix for dependency failures

* fix: fix for install failures

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ashish Reddy Podduturi <ashishrp@amazon.com>
Co-authored-by: aws-toolkit-automation <>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aws-toolkit-automation <>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aws-toolkit-automation <>
* Atx riv final (#2520)

* feat: add atx fes integration for transform profiles

* feat: implement Transform profile discovery via ATX FES with cache clearing

* fix: remove unsupported eu-central-1 region from ATX FES endpoints

* feat: add separate flow for RTS and ATX listavailableprofile api

* fix: remove profile handling from atxnettransformserver

* feat: separating qdev and aws transform

* fix: fixing unit tests

* fix: adding tests

* fix: updating as per langugae server runtime updates

* feat: add starttranform and workspace

* feat: added getTransformInfo and its support methods

* fix: with new runtimes

* feat: add stopjob support

* merged stopjob and added upload plan

* chore: force use of new runtimes

* fix: completed getting plan, worklogs, and final artifact

* chore: deleting unused RPC messages

* feat: added list worklogs before planning

* fix: remove unused methods

---------

Co-authored-by: Pranav Firake <pranavfi@amazon.com>
Co-authored-by: pranav firake <pranav.firake7@gmail.com>
Co-authored-by: Jordan Miao <gzmiao@amazon.com>

* fix: adding atxcredentials details

* fix: updating plan for completed status

* fix: separating aws atx and q credentials storage

* fix: changed customer_output to customer_input

* fix: added new atx-fes-client models to allow CUSTOMER_INPUT types

* fix: multiple accounts token auth

* fix: auto-sync transform profiles using TransformConfigurationServer and prevent us-east-1 defaults

* fix: set default fallback transform request from net 8 to net 10

* fix: changed back q flow to net 8, added target framework to create job requests

* fix: updates aws-server-runtimes to 0.3.8 and added Syd endpoint to constants

* fix: maintaining backwards compatibility

* fix: fixing failing test

* fix: fixing tests

* fix: get endpoints by stage

* fix: regex for appUrl not handling gamma stage and return default region

* fix: fix for initInstance and moved init of atx servers to be after base server is initialized

* fix: fixing tests

* fix: fixing tests

* fix: fixing tests

* chore: bumping lsp version to 0.3.8

* chore: revert naming from Q back to codewhisperer

* chore: deleting stale function

* chore: updating folder

* fix: changed transformserver to log caught errors instead of throwing

* chore: reverting changes and adding todo

* fix: tests with changes

* fix: tests with changes

* chore: removing debug logs

---------

Co-authored-by: Pranav Firake <pranavfi@amazon.com>
Co-authored-by: pranav firake <pranav.firake7@gmail.com>
Co-authored-by: Jordan Miao <gzmiao@amazon.com>
Co-authored-by: Sherry Lu <75588211+XiaoxuanLu@users.noreply.github.com>
Co-authored-by: Chris Long <longachr@amazon.com>
* chore(release): release packages from branch main

* fix(release): update package-lock.json

* fix(release): manually update versions in packages

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Manodnya Bhoite <manodnyb@amazon.com>
Co-authored-by: aws-toolkit-automation <>
github-actions bot and others added 30 commits December 1, 2025 12:03
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aws-toolkit-automation <>
* feat: use dynamic token limits from listAvailableModels API

* fix: dependency issues

* refactor: encapsulate model ID and token limits in session
* fix: corrected plan upload extension type

* fix: updated plan path for failed validation and fixed profile update bugs
* refactor: removed unreferenced code and refactored log messages

* refactor: removed test for unused methods

* fix: reverted error string messaging
…tests (#2547)

* refactor: moved common utility functions to a single file for transform handlers

* refactor: addressed comments

* fix: fixed uncaught error problem with worklogs

* fix: format changes
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: chungjac <chungjac@amazon.com>
Co-authored-by: aws-toolkit-automation <>
## Problem

transitive dependency `ansi-regex@2.1.1` was introduced with #654 

associated CVE link  https://nvd.nist.gov/vuln/detail/CVE-2021-3807


```
(base) ➜  runtimes git:(main) npm ls registry-js
@amzn/monorepo-language-server-runtimes@1.0.0 /Volumes/workplace/ide/language-server-runtimes
└─┬ @aws/language-server-runtimes@0.3.9 -> ./runtimes
  └── registry-js@1.16.1

(base) ➜  runtimes git:(main) npm ls ansi-regex
@amzn/monorepo-language-server-runtimes@1.0.0 /Volumes/workplace/ide/language-server-runtimes
└─┬ @aws/language-server-runtimes@0.3.9 -> ./runtimes
  ├─┬ copyfiles@2.4.1
  │ └─┬ yargs@16.2.0
  │   └─┬ cliui@7.0.4
  │     └─┬ strip-ansi@6.0.1
  │       └── ansi-regex@5.0.1
  └─┬ registry-js@1.16.1
    └─┬ prebuild-install@5.3.6
      └─┬ npmlog@4.1.2
        └─┬ gauge@2.7.4
          └─┬ strip-ansi@3.0.1
            └── ansi-regex@2.1.1
```


## Solution
use `winreg`

Microsoft winreg example
https://github.com/microsoft/azure-pipelines-tasks-common-packages/blob/680f186a1e10568b1493503c81d403220a2eeb22/common-npm-packages/webdeployment-common/msdeployutility.ts#L311-L320

## npm ls
```
(base) ➜  runtimes git:(security-v2) npm ls registry-js
@amzn/monorepo-language-server-runtimes@1.0.0 /Volumes/workplace/ide/language-server-runtimes
└── (empty)
```

```
(base) ➜  runtimes git:(security-v2) npm ls ansi-regex
@amzn/monorepo-language-server-runtimes@1.0.0 /Volumes/workplace/ide/language-server-runtimes
└─┬ @aws/language-server-runtimes@0.3.9 -> ./runtimes
  └─┬ copyfiles@2.4.1
    └─┬ yargs@16.2.0
      └─┬ cliui@7.0.4
        └─┬ strip-ansi@6.0.1
          └── ansi-regex@5.0.1
```
* fix: fix for mcp servers refresh

* fix: fix for failing unit tests
* feat: add websearch tool (#2540)

* feat: add webfetch tool (#2542)

* feat: add webfetch tool

* fix: typo

* fix: remove snippets from web search (#2543)

* fix: filter out invalid urls (#2546)

---------

Co-authored-by: aws-toolkit-automation <43144436+aws-toolkit-automation@users.noreply.github.com>
…ation (#2555)

* feat: add alphabetical sorting for MCP registry servers and improve URL validation

* fix: fix for failing unit test
* feat: update SMAI clients to use SM_AI_STUDIO_IDE origin

* fix: apply prettier formatting to utils.ts

* fix: formatting issues

* test: add tests for full coverage

* ci: trigger CI rerun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.