Skip to content

Remove in_place_update_true chef attribute from tests #7156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hgreebe wants to merge 1 commit into
base: develop
Choose a base branch
from
+0 −40
Open

Remove in_place_update_true chef attribute from tests #7156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions cli/tests/pcluster/validators/test_dev_settings_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,46 +20,6 @@
[
pytest.param(None, None, None, id="No extra chef attributes"),
pytest.param('{"other_attribute": "value"}', None, None, id="in_place_update_on_fleet_enabled not set"),
pytest.param(
'{"cluster": {"in_place_update_on_fleet_enabled": "true"}}',
None,
None,
id="in_place_update_true_string 'true' passes",
),
pytest.param(
'{"cluster": {"in_place_update_on_fleet_enabled": true}}',
None,
None,
id="in_place_update_true_string true passes",
),
pytest.param(
'{"cluster": {"in_place_update_on_fleet_enabled": "false"}}',
"When in-place updates are disabled, cluster updates are applied "
"by replacing compute and login nodes according to the selected QueueUpdateStrategy.",
FailureLevel.WARNING,
id="in_place_update_true_string 'false' throws a warning",
),
pytest.param(
'{"cluster": {"in_place_update_on_fleet_enabled": false}}',
"When in-place updates are disabled, cluster updates are applied "
"by replacing compute and login nodes according to the selected QueueUpdateStrategy.",
FailureLevel.WARNING,
id="in_place_update_true_string false throws a warning",
),
pytest.param(
'{"cluster": {"in_place_update_on_fleet_enabled": "invalid"}}',
"Invalid value in DevSettings/Cookbook/ExtraChefAttributes: "
"attribute 'in_place_update_on_fleet_enabled' must be a boolean value.",
FailureLevel.ERROR,
id="in_place_update_true_string invalid (string) throws an error",
),
pytest.param(
'{"cluster": {"in_place_update_on_fleet_enabled": 123}}',
"Invalid value in DevSettings/Cookbook/ExtraChefAttributes: "
"attribute 'in_place_update_on_fleet_enabled' must be a boolean value.",
FailureLevel.ERROR,
id="n_place_update_true_string invalid (number) throws an error",
),
],
)
def test_extra_chef_attributes_validator(extra_chef_attributes, expected_message, expected_failure_level):
Expand Down
Loading