Skip to content

Ignore empty website field in adoption #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kprahulraj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ignore empty website field in adoption #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/resource/bucket/hook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package bucket
import (
"context"
"fmt"
"reflect"
"strings"

"github.com/pkg/errors"
Expand Down Expand Up @@ -1685,7 +1686,7 @@ func (rm *resourceManager) syncWebsite(
ctx context.Context,
r *resource,
) (err error) {
if r.ko.Spec.Website == nil {
if r.ko.Spec.Website == nil || reflect.ValueOf(*r.ko.Spec.Website).IsZero() {
Copy link
Contributor

@knottnt knottnt Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have a unit test validating that deleteWebsite is called when Spec.Website is nil or empty.

return rm.deleteWebsite(ctx, r)
}
return rm.putWebsite(ctx, r)
Expand Down